AngersZhuuuu commented on a change in pull request #30957:
URL: https://github.com/apache/spark/pull/30957#discussion_r570723751
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystTypeConverters.scala
##########
@@ -174,6 +174,7 @@ object CatalystTypeConverters {
convertedIterable += elementConverter.toCatalyst(item)
}
new GenericArrayData(convertedIterable.toArray)
+ case g: GenericArrayData => new
GenericArrayData(g.array.map(elementConverter.toCatalyst))
Review comment:
> `toCatalystImpl` converts Scala data into Catalyst one but
`GenericArrayData` is Catalyst-internal, so this change looks weried.
For complex type, after use JsonToStruct, don't need this converter any
more. So I remove this.
How about current change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
