Github user shroffpradyumn commented on the pull request:
https://github.com/apache/spark/pull/5547#issuecomment-95797940
Thank you all for your feedback, and I apologize for my late reply (itâs
been a rough week of midterms).
@pwendell - Iâve addressed all your inline comments (memoization,
Javascript indentation, JSON lists, etc.) in my latest commit. As per the load
time of the graph, itâs improved a bit after moving from string
representations to JSON arrays, but only by a small factor.
When you say youâre skeptical about the graph scalability, what is the
maximum number of tasks you want displayed on the graph? Iâm thinking of
keeping it to 1000 (at the most), and having the users select a task range if
they want to view a different region of tasks (say tasks 1200-2000 for example).
My reason for the above is that the task stages become too cluttered above
a certain number, so itâs better to keep a limit, or alternatively, increase
the max height of the graph (which would involve a lot more scrolling though).
@andrewor14 - The visualization doesnât currently support zooming, and
it will definitely be pretty challenging to implement it on top of D3.js.
However, the task-range functionality I mentioned above can serve as a
pseudo-zoom feature since a user can select a task range and hence zoom into
the graph.
Also, breaking down the task times along the vertical axis shouldnât be
that difficult so we can definitely add that later on if required (provided
this patch gets accepted haha).
@punya - I havenât looked into using Amber yet, and Iâll definitely
check out plottable.js.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
