viirya commented on a change in pull request #30363:
URL: https://github.com/apache/spark/pull/30363#discussion_r571846243
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -3799,6 +3801,27 @@ class SQLConf extends Serializable with Logging {
}
}
+ private var definedConfsLoaded = false
+ /**
+ * init [[StaticSQLConf]] and [[org.apache.spark.sql.hive.HiveUtils]] so
that all the defined
+ * SQL Configurations will be registered to SQLConf
+ */
+ private def loadDefinedConfs(): Unit = {
+ if (!definedConfsLoaded) {
+ definedConfsLoaded = true
+ // Force to register static SQL configurations
+ StaticSQLConf
+ try {
+ // Force to register SQL configurations from Hive module
+ val symbol =
ScalaReflection.mirror.staticModule("org.apache.spark.sql.hive.HiveUtils")
+ ScalaReflection.mirror.reflectModule(symbol).instance
+ } catch {
+ case NonFatal(e) =>
+ logWarning("Cannot load sql configurations from hive module", e)
Review comment:
nit: This logging reads like there is a problem. But if we don't build
with Hive, it sounds no problem at all? Maybe rephrase to "SQL configurations
from Hive module is not loaded."?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
