Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5608#issuecomment-95905420
@shenh062326 yes, but you constructed it that way. I can construct a case
that works and doesn't work for any sampling strategy. The question is, what is
the common case? I'm pretty sure it's that all N objects share some common data
structure, which sampling just 1 would catch.
However if you want to go this way, at least generalize it. There is
nothing magic about 2 samples, so it shouldn't be written that way with a
redundant loop.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
