Github user ScrapCodes commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5662#discussion_r29041655
  
    --- Diff: 
repl/scala-2.11/src/main/scala/org/apache/spark/repl/SparkIMain.scala ---
    @@ -1129,7 +1129,7 @@ class SparkIMain(@BeanProperty val factory: 
ScriptEngineFactory, initialSettings
     
         def apply(line: String): Result = debugging(s"""parse("$line")""")  {
           var isIncomplete = false
    -      currentRun.reporting.withIncompleteHandler((_, _) => isIncomplete = 
true) {
    +      currentRun.parsing.withIncompleteHandler((_, _) => isIncomplete = 
true) {
    --- End diff --
    
    It is harmless, if not beneficial. But this can be a stepping stone towards 
enabling add jars, because then we have two options 1) back port scala's 
version of add jars 2) port spark scala 2.10 repl's version of add jars on the 
fly.
    
    Without this patch such a option does not exist. I agree best thing is to 
patch scala/scala so that we donot have to do it. So I am working on it, with 
whatever time I have.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to