HyukjinKwon commented on a change in pull request #31466: URL: https://github.com/apache/spark/pull/31466#discussion_r571911907
########## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ########## @@ -155,9 +155,13 @@ class SQLQueryTestSuite extends QueryTest with SharedSparkSession with SQLHelper .set(SQLConf.SHUFFLE_PARTITIONS, 4) /** List of test cases to ignore, in lower cases. */ - protected def ignoreList: Set[String] = Set( - "ignored.sql" // Do NOT remove this one. It is here to test the ignore functionality. - ) + protected val ignoreList: Set[String] = if (TestUtils.testCommandAvailable("/bin/bash")) { + // SPARK-32106 Since we add SQL test 'transform.sql' will use `cat` command, + // here we need to ignore it. + Set("ignored.sql", "transform.sql") + } else { + Set("ignored.sql") // Do NOT remove this one. It is here to test the ignore functionality. + } Review comment: ```suggestion protected val ignoreList: Set[String] = Set( "ignored.sql" // Do NOT remove this one. It is here to test the ignore functionality. ) ++ { // SPARK-32106 Since we add SQL test 'transform.sql' will use `cat` command, // here we need to ignore it. if (TestUtils.testCommandAvailable("/bin/bash")) Set("transform.sql") else Nil } ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org