cloud-fan commented on a change in pull request #31337: URL: https://github.com/apache/spark/pull/31337#discussion_r571985735
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala ########## @@ -504,8 +504,7 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]] extends Product { } } catch { case e: java.lang.IllegalArgumentException => - throw new TreeNodeException( - this, + throw new AnalysisException( Review comment: This is not analysis only. `IllegalStateException` should be fine as it indicates a bug. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org