tgravescs commented on a change in pull request #31521:
URL: https://github.com/apache/spark/pull/31521#discussion_r572100081
##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -719,10 +719,23 @@ class SparkContext(config: SparkConf) extends Logging {
if (value == null) {
localProperties.get.remove(key)
} else {
+ checkLocalProperty(key, value)
Review comment:
we should just change this to use the ConfigBuilder. mark it as internal
and the toBoolean function already does this same check to make sure valid.
That doesn't prevent them from doing it though so if we wanted to add other
checking for all internal that might be a bit more work and complex as I'm sure
we use some for testing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
