imback82 commented on a change in pull request #31494:
URL: https://github.com/apache/spark/pull/31494#discussion_r572290672
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableChange.java
##########
@@ -64,7 +64,20 @@ static TableChange setProperty(String property, String
value) {
* @return a TableChange for the addition
*/
static TableChange removeProperty(String property) {
Review comment:
Yes, the analyzer way seems better. But the rule will handle the
`ifExists = false` case and error out if the properties do not exist, instead
of removing the table changes for the `ifExists = true` case; catalog
implementation may want to log nonexistent properties to inform the user, for
example.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
