cloud-fan commented on pull request #31475: URL: https://github.com/apache/spark/pull/31475#issuecomment-776399717
I like the idea to allow the catalog implementations to distinguish between `TRUNCATE TABLE t` and `INSERT OVERWRITE t SELECT * FROM empty_table`. It seems fine to move the API to the table side. But the name conflict is a bit annoying. One idea is to keep the name `SupportsTruncate`, and put it in `org.apache.spark.sql.connector.catalog`, which is the same package of `SupportsDelete`. Then there is no conflict. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
