dongjoon-hyun commented on a change in pull request #31538:
URL: https://github.com/apache/spark/pull/31538#discussion_r573472762
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/RemoveNoopOperatorsSuite.scala
##########
@@ -44,6 +45,22 @@ class RemoveNoopOperatorsSuite extends PlanTest {
comparePlans(optimized, testRelation)
}
+ test("Do not remove projections with non-attribute expressions that reuse
expr ids") {
Review comment:
It seems that all newly added UTs fails with the following exception.
```
org.apache.spark.sql.catalyst.errors.package$TreeNodeException:
The structural integrity of the input plan is broken in
org.apache.spark.sql.catalyst.analysis.SimpleAnalyzer., tree:
```
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/RemoveNoopOperatorsSuite.scala
##########
@@ -44,6 +45,22 @@ class RemoveNoopOperatorsSuite extends PlanTest {
comparePlans(optimized, testRelation)
}
+ test("Do not remove projections with non-attribute expressions that reuse
expr ids") {
Review comment:
It seems that all newly added UTs fail with the following exception.
```
org.apache.spark.sql.catalyst.errors.package$TreeNodeException:
The structural integrity of the input plan is broken in
org.apache.spark.sql.catalyst.analysis.SimpleAnalyzer., tree:
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
