HeartSaVioR commented on pull request #31427: URL: https://github.com/apache/spark/pull/31427#issuecomment-776562258
I'm not feeling good with this too, but not from the code diff, but from the process. I understand lazy consensus on code is applied by default ASF policy and Spark project doesn't redefine the policy (by BYLAWS), but nowadays everyone (not only from Spark project but also from majority of projects) is struggling to make sure the PR has at least one approval from committer. That has been considered as an implicit policy. I'm not claiming that we should construct BYLAWS to make sure binding +1 is minimal requirement on code change, but I'd say lazy consensus must be considered as a last resort (similar weight on veto), like after suffering from finding reviewers for months even trying to get traction from dev@ mailing list. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
