sarutak commented on a change in pull request #31491:
URL: https://github.com/apache/spark/pull/31491#discussion_r574655496
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
##########
@@ -226,7 +226,7 @@ object JdbcUtils extends Logging {
case java.sql.Types.REAL => DoubleType
case java.sql.Types.REF => StringType
case java.sql.Types.REF_CURSOR => null
- case java.sql.Types.ROWID => LongType
+ case java.sql.Types.ROWID => StringType
Review comment:
Not only we can't assume the length of the ROWID but also it's not
required to be represented as integer.
JDBC RowId declares `getBytes` and `toString` to represent ROWID so I think
we can safely map ROWID to StringType.
https://docs.oracle.com/javase/8/docs/api/java/sql/RowId.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
