srowen commented on pull request #31461: URL: https://github.com/apache/spark/pull/31461#issuecomment-778251325
It's a good point - catalyst classes are not technically private, but by convention are not considered an API. People do hook into them anyway, at their own risk. My argument for this simple change to just open it anyway is basically: it will just keep the status-quo in Java 9+. Improving the API is a good thing, but will actually break some usages of UDT. Which is fine: they're not an API. But, I suppose it also means that changing it _later_, even after opening it as a DeveloperApi is not really much more disruptive. It's either that or indeed revive @viirya 's PR and get that merged. I also didn't hear objections, nor did I hear much review, which makes me uneasy as it's a fairly important internal component. I'd like to reach _some_ resolution here to keep the status quo working on Java 11, which we now support, and this is an imperfect but easy temporary fix. Is that reasonable? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
