Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4435#discussion_r29090015
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/exec/ExecutorsPage.scala 
---
    @@ -22,27 +22,28 @@ import javax.servlet.http.HttpServletRequest
     
     import scala.xml.Node
     
    +import org.apache.spark.status.api.v1.ExecutorSummary
     import org.apache.spark.ui.{ToolTips, UIUtils, WebUIPage}
     import org.apache.spark.util.Utils
     
    -/** Summary information about an executor to display in the UI. */
    -// Needs to be private[ui] because of a false positive MiMa failure.
    +// This isn't even used anymore -- but we need to keep it b/c of a MiMa 
false positive
     private[ui] case class ExecutorSummaryInfo(
    -    id: String,
    -    hostPort: String,
    -    rddBlocks: Int,
    -    memoryUsed: Long,
    -    diskUsed: Long,
    -    activeTasks: Int,
    -    failedTasks: Int,
    -    completedTasks: Int,
    -    totalTasks: Int,
    -    totalDuration: Long,
    -    totalInputBytes: Long,
    -    totalShuffleRead: Long,
    -    totalShuffleWrite: Long,
    -    maxMemory: Long,
    -    executorLogs: Map[String, String])
    +  id: String,
    --- End diff --
    
    nit: the previous indentation level was correct.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to