dongjoon-hyun commented on a change in pull request #31543:
URL: https://github.com/apache/spark/pull/31543#discussion_r575765476
##########
File path:
external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala
##########
@@ -725,6 +725,16 @@ abstract class AvroSuite
assert(result.sameElements(expected))
}
+ test("support user provided avro schema url") {
+ val avroSchemaUrl = testFile("test_sub.avsc")
+ val result = spark.read.option("avroSchemaUrl", avroSchemaUrl)
+ .format("avro")
+ .load(testAvro)
+ .collect()
+ val expected =
spark.read.format("avro").load(testAvro).select("string").collect()
+ assert(result.sameElements(expected))
+ }
Review comment:
Could you add more test cases? For example,
1. A test coverage for both `avroSchema` and `avroSchemaUrl` exist.
2. A negative test case for a wrong `avroSchemaUrl`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
