Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/4259#discussion_r29091444
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -42,34 +50,122 @@ private[regression] trait LinearRegressionParams
extends RegressorParams
class LinearRegression extends Regressor[Vector, LinearRegression,
LinearRegressionModel]
with LinearRegressionParams {
- setDefault(regParam -> 0.1, maxIter -> 100)
--- End diff --
minor: I think it is okay to leave the defaults here. It is easier for
users to read. We put some below params because we need to have the params
defined first.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
