dongjoon-hyun commented on a change in pull request #31562:
URL: https://github.com/apache/spark/pull/31562#discussion_r575902810
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceUtils.scala
##########
@@ -132,19 +133,23 @@ object DataSourceUtils {
}
def newRebaseExceptionInRead(format: String): SparkUpgradeException = {
- val config = format match {
- case "Parquet INT96" =>
SQLConf.LEGACY_PARQUET_INT96_REBASE_MODE_IN_READ.key
- case "Parquet" => SQLConf.LEGACY_PARQUET_REBASE_MODE_IN_READ.key
- case "Avro" => SQLConf.LEGACY_AVRO_REBASE_MODE_IN_READ.key
+ val (config, option) = format match {
+ case "Parquet INT96" =>
+ (SQLConf.LEGACY_PARQUET_INT96_REBASE_MODE_IN_READ.key,
ParquetOptions.INT96_REBASE_MODE)
+ case "Parquet" =>
+ (SQLConf.LEGACY_PARQUET_REBASE_MODE_IN_READ.key,
ParquetOptions.DATETIME_REBASE_MODE)
+ case "Avro" =>
+ (SQLConf.LEGACY_AVRO_REBASE_MODE_IN_READ.key, "datetimeRebaseMode")
Review comment:
I agree that this is inevitable because `AvroOptions` lives in external
module.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
