attilapiros commented on a change in pull request #31561:
URL: https://github.com/apache/spark/pull/31561#discussion_r576533332
##########
File path: core/src/test/scala/org/apache/spark/SparkFunSuite.scala
##########
@@ -160,6 +160,8 @@ abstract class SparkFunSuite
}
}
+ protected def logForFailedTest(): Unit = {}
Review comment:
The method `withFixture` which calls this `logForFailedTest` is `final`.
So either `logForFailedTest` must be here preferably with a default
implementation or the `final` should be removed from the `withFixture` method
but in that case the whole method `withFixture` should be copy-pasted to have
the log of the failed test in between the "===== TEST OUTPUT " and "=====
FINISHED" section (if this is required I think that is better then having it
after as it is part of the test).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
