Github user nchammas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5694#discussion_r29097695
  
    --- Diff: dev/run-tests ---
    @@ -17,239 +17,394 @@
     # limitations under the License.
     #
     
    -# Go to the Spark project root directory
    -FWDIR="$(cd "`dirname $0`"/..; pwd)"
    -cd "$FWDIR"
    +import os
    +import re
    +import shutil
    +import subprocess as sp
    +
    +# Set the Spark project root directory
    +spark_proj_root = os.path.abspath("..")
    --- End diff --
    
    The variable names and logic here are very clear, so I think we can do 
without all the comments in this whole starting block.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to