rdblue commented on a change in pull request #31575: URL: https://github.com/apache/spark/pull/31575#discussion_r577771433
########## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/AlterTableRenameSuite.scala ########## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.execution.command.v1 + +import org.apache.spark.sql.{AnalysisException, Row} +import org.apache.spark.sql.execution.command + +/** + * This base suite contains unified tests for the `ALTER TABLE .. RENAME` command that check V1 + * table catalogs. The tests that cannot run for all V1 catalogs are located in more + * specific test suites: + * + * - V1 In-Memory catalog: `org.apache.spark.sql.execution.command.v1.AlterTableRenameSuite` + * - V1 Hive External catalog: `org.apache.spark.sql.hive.execution.command.AlterTableRenameSuite` + */ +trait AlterTableRenameSuiteBase extends command.AlterTableRenameSuiteBase { + test("omit namespace in the destination table") { + withNamespaceAndTable("ns", "dst_tbl") { dst => + val src = dst.replace("dst", "src") + sql(s"CREATE TABLE $src (c0 INT) $defaultUsing") + sql(s"INSERT INTO $src SELECT 0") + + sql(s"ALTER TABLE $src RENAME TO dst_tbl") Review comment: > we can simply update the API doc of TableCatalog.renameTable and say: if the newIdent has no namespace, it means the namespace of oldIdent -1 for this idea. I think this is a mistake. This would introduce ambiguity in the API that requires the implementer to know how to do something correctly. In DSv2, we avoid those cases by making Spark a little smarter so that we have uniform behavior across sources. Instead of adding documentation, Spark should always pass the correct identifier for the rename. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
