HyukjinKwon commented on a change in pull request #31475:
URL: https://github.com/apache/spark/pull/31475#discussion_r578039193
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/SupportsDelete.java
##########
@@ -68,4 +69,15 @@ default boolean canDeleteWhere(Filter[] filters) {
* @throws IllegalArgumentException If the delete is rejected due to
required effort
*/
void deleteWhere(Filter[] filters);
+
+ Filter[] ALWAYS_TRUE_FILTER = new Filter[] { new AlwaysTrue() };
Review comment:
Can't people use `AlwaysTrue` directly if they want? I would also prefer
to avoid having multiple ways to do the same thing. It looks odd to have the
AlwaysTrue predicate constant as an API under `SupportsDelete` interface.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
