HeartSaVioR edited a comment on pull request #31580: URL: https://github.com/apache/spark/pull/31580#issuecomment-780931801
First of all, I'm sorry I think I'm giving ignorant inputs. Sorry for joining as novice. Where my concern came from is, we add a new method and use a new method nowhere here, which I can't imagine how it affects the behavior. If that is just to provide the information we lack in connector class (assuming data source devs don't know about the details on catalyst behaviors), that's a nice addition and thanks for doing it. Just I'd also like to think out loud to ask a question are there more ways we can give information here. If it's not just to provide the information but also affects the behavior or the method is somehow be leveraged in any way, please shed a light how, especially how this PR helps to enable below > Where this PR can be handy is if we want to support defining distribution or ordering in SQL statements (e.g. table creation). Then if the user just says ASC, we will parse it SortDirection.ASC and take the default null ordering. without adding any code in catalyst to call new method. If you have plans to leverage the new functionality, please share the plan and ideally file JIRA issues so that anyone doesn't misunderstand we're adding unused functionality. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
