sririshindra commented on a change in pull request #31477:
URL: https://github.com/apache/spark/pull/31477#discussion_r578044301
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashJoin.scala
##########
@@ -48,6 +48,13 @@ trait HashJoin extends BaseJoinExec with CodegenSupport {
s"$nodeName $joinType ${buildSide} ($opId)".trim
}
+ /**
+ * When overriding metrics be sure to include numOutputRows & numMatchedRows
+ */
+ override lazy val metrics = Map(
+ "numOutputRows" -> SQLMetrics.createMetric(sparkContext, "number of output
rows"),
+ "numMatchedRows" -> SQLMetrics.createMetric(sparkContext, "number of
matched rows"))
Review comment:
I removed the metrics from HashJoin in the latest commit and made the
numMatchedRows lazy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
