MaxGekk commented on a change in pull request #31577:
URL: https://github.com/apache/spark/pull/31577#discussion_r578141856
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala
##########
@@ -451,4 +451,14 @@ class SQLConfSuite extends QueryTest with
SharedSparkSession {
val e2 = intercept[ParseException](sql("set time zone interval 19 hours"))
assert(e2.getMessage contains "The interval value must be in the range of
[-18, +18] hours")
}
+
+ test("SPARK-34454: configs from the legacy namespace should be internal") {
+ val nonInternalLegacyConfigs = spark.sessionState.conf.getAllDefinedConfs
+ .filter { case (key, _, _, _) => key.contains(".legacy.") }
Review comment:
@dongjoon-hyun If you can guarantee that the legacy namespace can be
only inside of `spark.sql.` and not in any nested namespaces, let's change it.
> To be more clear that this is about SQL configs ...
It is pretty clear now. The test checks that any legacy configs are
internal. But now, you say no-no - not any, only one `spark.sql.legacy` because
somehow you guarantee that nobody adds a nested legacy namespace like
`spark.sql.super_feature.legacy.*`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
