cloud-fan commented on a change in pull request #31318:
URL: https://github.com/apache/spark/pull/31318#discussion_r579979106
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
##########
@@ -345,17 +345,18 @@ object BooleanSimplification extends Rule[LogicalPlan]
with PredicateHelper {
// Common factor elimination for conjunction
case and @ (left And right) =>
// 1. Split left and right to get the disjunctive predicates,
- // i.e. lhs = (a, b), rhs = (a, c)
+ // i.e. lhs = (a, b), rhs = (a, c)
Review comment:
nit: since we are updating this, let's change this to `lhs = (a || b)`
to make it clearer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
