Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4450#discussion_r29112553
  
    --- Diff: 
core/src/main/scala/org/apache/spark/util/collection/ExternalSorter.scala ---
    @@ -113,11 +114,21 @@ private[spark] class ExternalSorter[K, V, C](
         if (shouldPartition) partitioner.get.getPartition(key) else 0
       }
     
    +  private val metaInitialRecords = 
conf.getInt("spark.shuffle.sort.metaInitialRecords", 256)
    +  private val kvChunkSize = conf.getInt("spark.shuffle.sort.kvChunkSize", 
8192)
    --- End diff --
    
    Also, any reason to make this tunable in the first place? I think ideally 
we'd just have a value we're comfortable hard coding.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to