srowen commented on a change in pull request #30745:
URL: https://github.com/apache/spark/pull/30745#discussion_r580396516
##########
File path: python/pyspark/sql/functions.py
##########
@@ -222,6 +222,45 @@ def sum_distinct(col):
return _invoke_function_over_column("sum_distinct", col)
+def product(col, scale=1.0):
+ """
+ Aggregate function: returns the product of the values in a group.
+
+ .. versionadded:: 3.2.0
+
+ Parameters
+ ----------
+ col : str, :class:`Column`
+ column containing values to be multiplied together
+ scale : float
Review comment:
Yes, for all of the APIs. I mean, don't you just remove the params and
simplify to the case where scale = 1?
@HyukjinKwon do you have an opinion on this one
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
