AngersZhuuuu commented on pull request #31522: URL: https://github.com/apache/spark/pull/31522#issuecomment-783854398
> The file commit is a driver side thing, why do we need to update `BasicWriteJobStatsTracker`? I think we can follow `BroadcastExchangeExec` and simply call `SQLMetrics.postDriverMetricUpdates` Since we compute WritingCommand's metrics in driver side and all metrics stored in `BasicWriteJobStatsTracker `, so I changed `BasicWriteJobStatsTracker`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
