Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/5661#issuecomment-96450719
@hhbyyh Thanks for the PR! It looks good, except for 1 item on which I
think we weren't clear before:
I meant for us to separate the Optimizer and LearningState concepts.
* Optimizer should be a class which stores parameters and not much else.
Optimizer.initialState should return an instance of a LearningState class.
* LearningState should have the next() and getModel() methods.
Could you please refactor according to that? It should only require moving
code some, but I think it will help clarify the distinction between the
parameters and the learning state.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
