maropu commented on a change in pull request #31624:
URL: https://github.com/apache/spark/pull/31624#discussion_r581568580
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
##########
@@ -49,8 +49,16 @@ object DateTimeUtils {
final val TimeZoneUTC = TimeZone.getTimeZone("UTC")
val TIMEZONE_OPTION = "timeZone"
+ val TIME_ZONE_ID = "(\\+|\\-)\\d:".r
- def getZoneId(timeZoneId: String): ZoneId = ZoneId.of(timeZoneId,
ZoneId.SHORT_IDS)
+ def getZoneId(timeZoneId: String): ZoneId = {
+ var id = timeZoneId
Review comment:
Could you avoid using `var` here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
