gengliangwang commented on a change in pull request #31522:
URL: https://github.com/apache/spark/pull/31522#discussion_r582067232
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala
##########
@@ -221,7 +221,7 @@ object FileFormatWriter extends Logging {
val (_, duration) = Utils.timeTakenMs { committer.commitJob(job,
commitMsgs) }
logInfo(s"Write Job ${description.uuid} committed. Elapsed time:
$duration ms.")
- processStats(description.statsTrackers, ret.map(_.summary.stats))
+ processStats(description.statsTrackers, ret.map(_.summary.stats),
duration)
Review comment:
Normally, this should be fast. I don't think it is a good idea to put
this in the SQL graph. For debug purpose, the log message should be enough.
Besides, the name "duration of committing the job" can be confusing to
end-users.
I have to leave -1 for this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
