cloud-fan commented on a change in pull request #31595:
URL: https://github.com/apache/spark/pull/31595#discussion_r582118849
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala
##########
@@ -1021,108 +1021,108 @@ class SubquerySuite extends QueryTest with
SharedSparkSession with AdaptiveSpark
// Simple order by
val query1 =
"""
- |SELECT c1 FROM t1
- |WHERE
- |c1 IN (SELECT c1 FROM t2 ORDER BY c1)
+ |SELECT c1 FROM t1
+ |WHERE
+ |c1 IN (SELECT c1 FROM t2 ORDER BY c1)
""".stripMargin
assert(getNumSortsInQuery(query1) == 0)
// Nested order bys
val query2 =
"""
- |SELECT c1
- |FROM t1
- |WHERE c1 IN (SELECT c1
- | FROM (SELECT *
- | FROM t2
- | ORDER BY c2)
- | ORDER BY c1)
+ |SELECT c1
+ |FROM t1
+ |WHERE c1 IN (SELECT c1
+ | FROM (SELECT *
+ | FROM t2
+ | ORDER BY c2)
+ | ORDER BY c1)
""".stripMargin
assert(getNumSortsInQuery(query2) == 0)
// nested IN
val query3 =
"""
- |SELECT c1
- |FROM t1
- |WHERE c1 IN (SELECT c1
- | FROM t2
- | WHERE c1 IN (SELECT c1
- | FROM t3
- | WHERE c1 = 1
- | ORDER BY c3)
- | ORDER BY c2)
+ |SELECT c1
+ |FROM t1
+ |WHERE c1 IN (SELECT c1
+ | FROM t2
+ | WHERE c1 IN (SELECT c1
+ | FROM t3
+ | WHERE c1 = 1
+ | ORDER BY c3)
+ | ORDER BY c2)
""".stripMargin
assert(getNumSortsInQuery(query3) == 0)
// Complex subplan and multiple sorts
val query4 =
"""
- |SELECT c1
- |FROM t1
- |WHERE c1 IN (SELECT c1
- | FROM (SELECT c1, c2, count(*)
- | FROM t2
- | GROUP BY c1, c2
- | HAVING count(*) > 0
- | ORDER BY c2)
- | ORDER BY c1)
+ |SELECT c1
+ |FROM t1
+ |WHERE c1 IN (SELECT c1
+ | FROM (SELECT c1, c2, count(*)
+ | FROM t2
+ | GROUP BY c1, c2
+ | HAVING count(*) > 0
+ | ORDER BY c2)
+ | ORDER BY c1)
""".stripMargin
assert(getNumSortsInQuery(query4) == 0)
// Join in subplan
val query5 =
"""
- |SELECT c1 FROM t1
- |WHERE
- |c1 IN (SELECT t2.c1 FROM t2, t3
- | WHERE t2.c1 = t3.c1
- | ORDER BY t2.c1)
+ |SELECT c1 FROM t1
+ |WHERE
+ |c1 IN (SELECT t2.c1 FROM t2, t3
+ | WHERE t2.c1 = t3.c1
+ | ORDER BY t2.c1)
""".stripMargin
assert(getNumSortsInQuery(query5) == 0)
val query6 =
"""
- |SELECT c1
- |FROM t1
- |WHERE (c1, c2) IN (SELECT c1, max(c2)
- | FROM (SELECT c1, c2, count(*)
- | FROM t2
- | GROUP BY c1, c2
- | HAVING count(*) > 0
- | ORDER BY c2)
- | GROUP BY c1
- | HAVING max(c2) > 0
- | ORDER BY c1)
+ |SELECT c1
+ |FROM t1
+ |WHERE (c1, c2) IN (SELECT c1, max(c2)
+ | FROM (SELECT c1, c2, count(*)
+ | FROM t2
+ | GROUP BY c1, c2
+ | HAVING count(*) > 0
+ | ORDER BY c2)
+ | GROUP BY c1
+ | HAVING max(c2) > 0
+ | ORDER BY c1)
""".stripMargin
assert(getNumSortsInQuery(query6) == 0)
// Cases when sort is not removed from the plan
// Limit on top of sort
val query7 =
- """
- |SELECT c1 FROM t1
- |WHERE
- |c1 IN (SELECT c1 FROM t2 ORDER BY c1 limit 1)
+ """
Review comment:
are these indentation changes valid?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
