shardulm94 commented on a change in pull request #31623:
URL: https://github.com/apache/spark/pull/31623#discussion_r582304805
##########
File path: core/src/main/scala/org/apache/spark/util/DependencyUtils.scala
##########
@@ -59,8 +59,8 @@ private[spark] object DependencyUtils extends Logging {
* @param uri Ivy URI need to be downloaded.
* @return Tuple value of parameter `transitive` and `exclude` value.
*
- * 1. transitive: whether to download dependency jar of Ivy URI,
default value is false
- * and this parameter value is case-sensitive. Invalid value will
be treat as false.
+ * 1. transitive: whether to download dependency jar of Ivy URI,
default value is true
+ * and this parameter value is case-insensitive. Invalid value
will be treat as false.
Review comment:
Fixed
##########
File path: core/src/main/scala/org/apache/spark/util/DependencyUtils.scala
##########
@@ -59,8 +59,8 @@ private[spark] object DependencyUtils extends Logging {
* @param uri Ivy URI need to be downloaded.
* @return Tuple value of parameter `transitive` and `exclude` value.
*
- * 1. transitive: whether to download dependency jar of Ivy URI,
default value is false
- * and this parameter value is case-sensitive. Invalid value will
be treat as false.
+ * 1. transitive: whether to download dependency jar of Ivy URI,
default value is true
+ * and this parameter value is case-insensitive. Invalid value
will be treat as false.
Review comment:
Done
##########
File path: docs/sql-ref-syntax-aux-resource-mgmt-add-jar.md
##########
@@ -36,7 +36,7 @@ ADD JAR file_name
The name of the JAR file to be added. It could be either on a local file
system or a distributed file system or an Ivy URI.
Apache Ivy is a popular dependency manager focusing on flexibility and
simplicity. Now we support two parameter in URI query string:
- * transitive: whether to download dependent jars related to your ivy URL.
It is case-sensitive and only take last one if multiple transitive parameters
are specified.
+ * transitive: whether to download dependent jars related to your ivy URL.
The parameter name is case-sensitive, parameter value is case-insensitive and
only take last one if multiple transitive parameters are specified.
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
