maropu commented on a change in pull request #30648:
URL: https://github.com/apache/spark/pull/30648#discussion_r582406908
##########
File path: docs/sql-ref-syntax-aux-analyze.md
##########
@@ -20,3 +20,4 @@ license: |
---
* [ANALYZE TABLE statement](sql-ref-syntax-aux-analyze-table.html)
+ * [ANALYZE TABLES statement](sql-ref-syntax-aux-analyze-tables.html)
Review comment:
plz update the index page, too.
##########
File path: docs/sql-ref-syntax-aux-analyze-tables.md
##########
@@ -0,0 +1,149 @@
+---
+layout: global
+title: ANALYZE TABLES
+displayTitle: ANALYZE TABLES
+license: |
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+---
+
+### Description
+
+The `ANALYZE TABLES` statement collects statistics about all the tables in a
database to be used by the query optimizer to find a better query execution
plan.
Review comment:
nit: `in a database` -> `in a specified database`?
##########
File path: docs/sql-ref-syntax-aux-analyze-tables.md
##########
@@ -0,0 +1,149 @@
+---
+layout: global
+title: ANALYZE TABLES
+displayTitle: ANALYZE TABLES
+license: |
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+---
+
+### Description
+
+The `ANALYZE TABLES` statement collects statistics about all the tables in a
database to be used by the query optimizer to find a better query execution
plan.
+
+### Syntax
+
+```sql
+ANALYZE TABLES [ { FROM | IN } database_name ] COMPUTE STATISTICS [ NOSCAN ]
+```
+
+### Parameters
+
+* **{ FROM `|` IN } database_name**
+
+ Specifies the name of the database to be analyzed. Without a database
name, `ANALYZE` collects all tables in the current database that the current
user has permission to analyze.
+
+* **[ NOSCAN ]**
+
+ Collects only the table's size in bytes ( which does not require scanning
the entire table ).
+
+### Examples
+
+```sql
+CREATE DATABASE school_db;
+USE school_db;
+
+CREATE TABLE teachers (name STRING, teacher_id INT);
+INSERT INTO teachers VALUES ('Tom', 1), ('Jerry', 2);
+
+CREATE TABLE students (name STRING, student_id INT);
+INSERT INTO students VALUES ('Mark', 111111), ('John', 222222);
+
+ANALYZE TABLES IN school_db COMPUTE STATISTICS NOSCAN;
+
+SHOW TABLE EXTENDED IN school_db LIKE '*';
++------------+------------+--------------+----------------------------------------------------+
+| database | tableName | isTemporary | information
|
++------------+------------+--------------+----------------------------------------------------+
+|school_db |students |false |Database: school_db
+ Table: students
+ Owner: root
+ Created Time: Wed Dec 09 14:23:25
CST 2020
+ Last Access: UNKNOWN
+ Created By: Spark 3.2.0-SNAPSHOT
+ Type: MANAGED
+ Provider: hive
+ Table Properties:
[transient_lastDdlTime=1607495032]
+ Statistics: 24 bytes
+ Location:
file:/opt/spark1/spark/spark-warehouse/school_db.db/students
+ Serde Library:
org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe
+ InputFormat:
org.apache.hadoop.mapred.TextInputFormat
+ OutputFormat:
org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat
+ Storage Properties:
[serialization.format=1]
+ Partition Provider: Catalog
+ Schema: root
+ |-- name: string (nullable = true)
+ |-- student_id: integer (nullable =
true) |
+|school_db |teachers |false |Database: school_db
+ Table: teachers
+ Owner: root
+ Created Time: Wed Dec 09 14:24:15
CST 2020
+ Last Access: UNKNOWN
+ Created By: Spark 3.2.0-SNAPSHOT
+ Type: MANAGED
+ Provider: hive
+ Table Properties:
[transient_lastDdlTime=1607495059]
+ Statistics: 14 bytes
+ Location:
file:/opt/spark1/spark/spark-warehouse/school_db.db/teachers
+ Serde Library:
org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe
+ InputFormat:
org.apache.hadoop.mapred.TextInputFormat
+ OutputFormat:
org.apache.hadoop.hive.ql.io.HiveIgnoreKeyTextOutputFormat
+ Storage Properties:
[serialization.format=1]
+ Partition Provider: Catalog
+ Schema: root
+ |-- name: string (nullable = true)
+ |-- teacher_id: integer (nullable =
true) |
++------------+------------+--------------+----------------------------------------------------+
+
+ANALYZE TABLES COMPUTE STATISTICS;
+
+SHOW TABLE EXTENDED IN school_db LIKE '*';
++------------+------------+--------------+----------------------------------------------------+
+| database | tableName | isTemporary | information
|
++------------+------------+--------------+----------------------------------------------------+
+|school_db |students |false |Database: school_db
+ Table: students
+ Owner: root
+ Created Time: Wed Dec 09 14:23:25
CST 2020
+ Last Access: UNKNOWN
+ Created By: Spark 3.2.0-SNAPSHOT
+ Type: MANAGED
+ Provider: hive
+ Table Properties:
[transient_lastDdlTime=1607495311]
+ Statistics: 24 bytes, 2 rows
+ Location:
file:/opt/spark1/spark/spark-warehouse/school_db.db/students
Review comment:
Could you use `DESC EXTENDED` to follow the `ANALYZE TABLE` example?
https://spark.apache.org/docs/3.0.2/sql-ref-syntax-aux-analyze-table.html I
think the current example has many unnecessary information. The simpler is the
better.
##########
File path: docs/sql-ref-syntax-aux-analyze-tables.md
##########
@@ -0,0 +1,149 @@
+---
+layout: global
+title: ANALYZE TABLES
+displayTitle: ANALYZE TABLES
+license: |
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+---
+
+### Description
+
+The `ANALYZE TABLES` statement collects statistics about all the tables in a
database to be used by the query optimizer to find a better query execution
plan.
+
+### Syntax
+
+```sql
+ANALYZE TABLES [ { FROM | IN } database_name ] COMPUTE STATISTICS [ NOSCAN ]
+```
+
+### Parameters
+
+* **{ FROM `|` IN } database_name**
+
+ Specifies the name of the database to be analyzed. Without a database
name, `ANALYZE` collects all tables in the current database that the current
user has permission to analyze.
Review comment:
We need t say `...that the current user has permission to analyze.` here?
https://github.com/apache/spark/blame/master/docs/sql-ref-syntax-aux-show-tables.md#L39
##########
File path: docs/sql-ref-syntax-aux-analyze-tables.md
##########
@@ -0,0 +1,149 @@
+---
+layout: global
+title: ANALYZE TABLES
+displayTitle: ANALYZE TABLES
+license: |
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+---
+
+### Description
+
+The `ANALYZE TABLES` statement collects statistics about all the tables in a
database to be used by the query optimizer to find a better query execution
plan.
+
+### Syntax
+
+```sql
+ANALYZE TABLES [ { FROM | IN } database_name ] COMPUTE STATISTICS [ NOSCAN ]
+```
+
+### Parameters
+
+* **{ FROM `|` IN } database_name**
+
+ Specifies the name of the database to be analyzed. Without a database
name, `ANALYZE` collects all tables in the current database that the current
user has permission to analyze.
+
+* **[ NOSCAN ]**
+
+ Collects only the table's size in bytes ( which does not require scanning
the entire table ).
Review comment:
nit: it seems unnecessary spaces found: `( which` and `table )`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
