cloud-fan commented on a change in pull request #31641:
URL: https://github.com/apache/spark/pull/31641#discussion_r582775569
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/EliminateJoinToEmptyRelation.scala
##########
@@ -33,6 +34,9 @@ import
org.apache.spark.sql.execution.joins.{EmptyHashedRelation, HashedRelation
* This applies to all Joins (sort merge join, shuffled hash join, and
broadcast hash join),
* because sort merge join and shuffled hash join will be changed to
broadcast hash join with AQE
* at the first place.
+ *
+ * 3. Join is left anti join without condition, and broadcasted join right
side is not empty.
+ * This applies to broadcast nested loop join only.
Review comment:
Why do we care about the physical plan? I think it's a logical
optimization that left anti join without condition can be turned into empty
relation if right side is non-empty.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
