Yikun edited a comment on pull request #31454: URL: https://github.com/apache/spark/pull/31454#issuecomment-785874471
> How can we test that it is running the build using zinc? @odidev Sorry for late reply, and looks like there is some misleading content in my last reply. Actually, the scala-maven-plugin v4.0.0 already support the new version Zinc 1.x with multi-arch support rather than scalor-maven-plugin. [1] So, you can just use the scala-maven-plugin v4.X to enable the Zinc incremental compiler in aarch64 and also x86. > If we can fix it not invasively, I think it's fine to add zinc back in aarch64 too. @HyukjinKwon And when I do investigation on the Zinc multi-arch support, I found there is bug [SPARK-34539](https://issues.apache.org/jira/projects/SPARK/issues/SPARK-34539 ), looks like the zinc server code can be cleanup completely after we bump the scala-maven-plugin to v4.X in [SPARK-28759](https://issues.apache.org/jira/browse/SPARK-28759), because the zinc increamental compiler has been [enabled by default](https://github.com/davidB/scala-maven-plugin/commit/0f01f2fe37aaadbefb02fb713d469dbd10acf8b1)[2] in scala-maven-plugin 4.X. [1] https://github.com/davidB/scala-maven-plugin/pull/321 [2] https://github.com/davidB/scala-maven-plugin/commit/0f01f2fe37aaadbefb02fb713d469dbd10acf8b1 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
