viirya commented on pull request #31476: URL: https://github.com/apache/spark/pull/31476#issuecomment-786112772
I think we have a couple choices. * When we aggregate the metrics, for `V2_CUSTOM` metric type, we access the `SQLMetric` from `AccumulatorContext` and call its aggregate method. For built-in metrics, just call `SQLMetrics.stringValue` as usual. * Replace `metricsType` with a general aggregating function. We propagate it through `SQLMetricInfo`, `SQLPlanMetric`, etc. In SQL UI component, we call the aggregating. But these are implementation details, I think the choice doesn't affect the public API here. Do you prefer to make the choice here and put it into same PR, or we polish the public API only in this PR and then create another PR for implementation? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
