yikf commented on pull request #31648: URL: https://github.com/apache/spark/pull/31648#issuecomment-786334052
> The change in `SortShuffleManager` looks good to me. However, we should add a UT to cover this. Also, I don't quite get how the change in `StringExpressionsSuite.scala` is related to this bug fix. The change in `StringExpressionsSuite.scala` is unrelated to this bug fix, for code simplifications only. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
