cloud-fan commented on a change in pull request #31641:
URL: https://github.com/apache/spark/pull/31641#discussion_r583355683
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala
##########
@@ -1230,6 +1237,30 @@ class AdaptiveQueryExecSuite
}
}
+ test("SPARK-34533: Eliminate left anti join to empty relation") {
+ withSQLConf(
+ SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "true") {
+ withTable("emptyTestData") {
+ spark.range(0).write.saveAsTable("emptyTestData")
+ Seq(
+ // broadcast non-empty right side
+ ("SELECT /*+ broadcast(testData3) */ * FROM testData LEFT ANTI JOIN
testData3", true),
+ // broadcast empty right side
+ ("SELECT /*+ broadcast(emptyTestData) */ * FROM testData LEFT ANTI
JOIN emptyTestData",
+ false),
+ // broadcast left side
+ ("SELECT /*+ broadcast(testData) */ * FROM testData LEFT ANTI JOIN
testData3", false)
+ ).foreach { case (query, isEliminated) =>
+ val (plan, adaptivePlan) = runAdaptiveAndVerifyResult(query)
+ val bnlj = findTopLevelBroadcastNestedLoopJoin(plan)
Review comment:
Do we need to create `findTopLevelBroadcastNestedLoopJoin`? We just want
to prove that, the non-AQE plan has join and the AQE one has no join.
`findTopLevelBaseJoin` should be good enough here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
