maropu commented on a change in pull request #31656:
URL: https://github.com/apache/spark/pull/31656#discussion_r583607931
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -157,8 +157,8 @@ abstract class Optimizer(catalogManager: CatalogManager)
// since the other rules might make two separate Unions operators
adjacent.
Batch("Union", Once,
RemoveNoopOperators,
- RemoveNoopUnion,
- CombineUnions) ::
+ CombineUnions,
+ RemoveNoopUnion) ::
Review comment:
Does the added test in `DataFrameSetOperationsSuite` fail without this
reorder? The change itself looks reasonable though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
