maropu commented on a change in pull request #31598:
URL: https://github.com/apache/spark/pull/31598#discussion_r584022481
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
##########
@@ -914,7 +927,21 @@ object SparkSession extends Logging {
*/
def getOrCreate(): SparkSession = synchronized {
val sparkConf = new SparkConf()
- options.foreach { case (k, v) => sparkConf.set(k, v) }
+ val (nonEffectConfigurations, mayEffectConfigurations) =
+ options.partition { case (key: String, _) =>
+ DRIVER_RELATED_LAUNCHER_CONFIG.exists(keys => key.startsWith(keys))
+ }
+
+ if (nonEffectConfigurations.nonEmpty) {
+ logWarning(
+ "Since spark has been submitted, such configurations" +
+ s" `${nonEffectConfigurations.mkString(", ")}` may not take
effect." +
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
