Github user rayortigas commented on the pull request:
https://github.com/apache/spark/pull/5713#issuecomment-96753069
Hi @punya.
Re: Scala and Java types, are you talking about:
a) the code similarities between `createToScalaConverter(DataType)` and
(`createToProductConverter[T]` + `createToScalaConverter(universe.Type,
DataType)`)? I think after introducing this typed path I would like to DRY up
the code. Just wanted to propose a minimally invasive commit for now.
b) the general approach for Scala/Java-Catalyst conversions? I can see that
[ScalaReflection](https://github.com/apache/spark/blob/d56c3e0155dc50d3656f2b21cb7ed1407ea06b7e/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala#L112)
and
[JavaTypeInference](https://github.com/apache/spark/blob/d56c3e0155dc50d3656f2b21cb7ed1407ea06b7e/sql/core/src/main/scala/org/apache/spark/sql/JavaTypeInference.scala#L53)
do similar things, but don't know enough about the design to know whether this
is ripe for refactoring. If it hasn't been done or scheduled, maybe someone
should do a survey of the current state of things.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
