Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3636#discussion_r29171057
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/optimization/GradientDescent.scala
---
@@ -142,7 +157,10 @@ object GradientDescent extends Logging {
* @param regParam - regularization parameter
* @param miniBatchFraction - fraction of the input data set that should
be used for
* one iteration of SGD. Default value 1.0.
- *
+ * @param convergenceTol - Minibatch iteration will end before
numIterations if the
--- End diff --
There should not be a leading "-" for these parameters. (I know you're
just following previous work, but can you please remove them?)
Also, please update doc based on using weight vector (not loss) and using
relative change
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
