MaxGekk commented on a change in pull request #31676:
URL: https://github.com/apache/spark/pull/31676#discussion_r584457646
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala
##########
@@ -347,7 +347,7 @@ case class DescribeRelation(
partitionSpec: TablePartitionSpec,
isExtended: Boolean) extends Command {
override def children: Seq[LogicalPlan] = Seq(relation)
- override def output: Seq[Attribute] =
DescribeCommandSchema.describeTableAttributes()
+ override val output: Seq[Attribute] =
DescribeCommandSchema.describeTableAttributes()
Review comment:
> Shall we follow others like ShowTables and put the output as a
parameter?
Put the `output` as a parameter doesn't solve any problems.
> Then it's more stable ...
I would say "super stable" even it is not necessary, see
https://github.com/apache/spark/pull/31675
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
