MaxGekk commented on a change in pull request #31675:
URL: https://github.com/apache/spark/pull/31675#discussion_r584461988
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala
##########
@@ -491,13 +491,10 @@ case class RenameTable(
*/
case class ShowTables(
namespace: LogicalPlan,
- pattern: Option[String],
- override val output: Seq[Attribute] = ShowTables.OUTPUT) extends Command {
+ pattern: Option[String]) extends Command {
override def children: Seq[LogicalPlan] = Seq(namespace)
-}
-object ShowTables {
- val OUTPUT = Seq(
Review comment:
This just introduces unnecessary boilerplate code. I don't see any
benefits of that. Could you explain the motivation of having the `ShowTables`
object with a method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
