cloud-fan commented on a change in pull request #31654: URL: https://github.com/apache/spark/pull/31654#discussion_r584462469
########## File path: sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala ########## @@ -2492,6 +2492,35 @@ class DataSourceV2SQLSuite } } + test("SPARK-34547: metadata columns are resolved last") { + val t1 = s"${catalogAndNamespace}tableOne" + val t2 = s"${catalogAndNamespace}tableTwo" + withTable(t1, t2) { + sql(s"CREATE TABLE $t1 (id bigint, data string) USING $v2Format " + + "PARTITIONED BY (bucket(4, id), id)") + sql(s"INSERT INTO $t1 VALUES (1, 'a'), (2, 'b'), (3, 'c')") + sql(s"CREATE TABLE $t2 (id bigint, index int) USING $v2Format") Review comment: I think the test is to join a v2 table with a relation, while the relation output has name conflicts with the v2 table's metadata output. It doesn't matter what the relation is and we can use a temp view to simplify the test. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org