cloud-fan commented on a change in pull request #31682:
URL: https://github.com/apache/spark/pull/31682#discussion_r584488733
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameStatSuite.scala
##########
@@ -436,7 +436,7 @@ class DataFrameStatSuite extends QueryTest with
SharedSparkSession {
val df = spark.range(0, 100)
.select(lit("Foo").as("name"), (col("id") % 3).as("key"))
val sampled = df.stat.sampleBy(
- struct($"name", $"key"), Map(Row("Foo", 0) -> 0.1, Row("Foo", 1) ->
0.2), 0L)
+ struct($"name", $"key"), Map(Row("Foo", 0L) -> 0.1, Row("Foo", 1L) ->
0.2), 0L)
Review comment:
what happens if we don't add the suffix `L`? If it fails when it seems a
breaking change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
