maropu commented on a change in pull request #28715:
URL: https://github.com/apache/spark/pull/28715#discussion_r584503039
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
##########
@@ -51,6 +51,84 @@ class WholeStageCodegenSuite extends QueryTest with
SharedSparkSession
assert(df.collect() === Array(Row(9, 4.5)))
}
+ test("GenerateExec should be included in WholeStageCodegen") {
+ import testImplicits._
+ val arrayData = Seq(("James", Seq("Java", "Scala"), Map("hair" -> "black",
"eye" -> "brown")))
+ val df = arrayData.toDF("name", "knownLanguages", "properties")
+
+ // Array - explode
+ var expDF = df.select($"name", explode($"knownLanguages"), $"properties")
+ var plan = expDF.queryExecution.executedPlan
+ assert(plan.find {
+ case stage: WholeStageCodegenExec =>
+ stage.find(_.isInstanceOf[GenerateExec]).isDefined
+ case _ => false
+ }.isDefined)
+ checkAnswer(expDF, Array(Row("James", "Java", Map("hair" -> "black", "eye"
-> "brown")),
Review comment:
Could you use `testWithWholeStageCodegenOnAndOff` to check if queries
work correctly with/without codegen?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
