xkrogen opened a new pull request #31694: URL: https://github.com/apache/spark/pull/31694
### What changes were proposed in this pull request? Add the `ResetSystemProperties` trait to `SQLQuerySuite` so that system property changes made by any of the tests will not affect other suites/tests. Specifically, the system property changes made by `SPARK-33084: Add jar support Ivy URI in SQL -- jar contains udf class` are targeted here. Additionally, update the system property used by the test to adjust the Ivy home directory from `ivy.home` to `ivy.default.ivy.user.dir`. ### Why are the changes needed? PR #29966 added a new test case that adjusts the `ivy.home` system property to force Ivy to resolve an artifact from a custom location. At the end of the test, the value is cleared. Clearing the value meant that, if a custom value of `ivy.home` was configured externally, it would not apply for tests run after this test case. Additionally, the `ivy.home` property is treated by Ivy as synonymous to the `ivy.default.ivy.user.dir` property, except that the latter takes precedence. Thus, if `ivy.default.ivy.user.dir` was externally configured, this test would fail, since the `ivy.home` value would not take effect. ### Does this PR introduce _any_ user-facing change? No, this is only in tests. ### How was this patch tested? Previously, if the tests were launched with a system property value of `ivy.default.ivy.user.dir = /path/to/custom/location`, the test in question would fail. Now, it succeeds. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
